Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Navigation Url when external link - MEED-7881 - Meeds-io/meeds#2622 #4215

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

boubaker
Copy link
Member

@boubaker boubaker commented Dec 3, 2024

Prior to this change, the external link behavior wasn't the same switch Navigation Node display mode:

  • Desktop Menu Item
  • Desktop Menu Sub item (displayed in Second or Third Level)
  • Mobile Menu Item
  • Mobile Menu Sub item (displayed in Second or Third Level)

Thus, when clicking on external link in Mobile, the behavior is just to open the URL as it was a current page URL. This change will introduce the usage of AutoLink API in order to ensure the URL behavior consistency comparing to provided link by the user. In addition, when a Dash is used in user provided URL, the behavior has been improved to always open the URL and not let the builtin behavior occurs, which will not change to the opened page.

…ds#2622

Prior to this change, the external link behavior wasn't the same switch Navigation Node display mode:
- Desktop Menu Item
- Desktop Menu Sub item (displayed in Second or Third Level)
- Mobile Menu Item
- Mobile Menu Sub item (displayed in Second or Third Level)

Thus, when clicking on external link in Mobile, the behavior is just to open the URL as it was a current page URL.
This change will introduce the usage of **AutoLink** API in order to ensure the URL behavior consistency comparing to provided link by the user.
In addition, when a Dash is used in user provided URL, the behavio has been improved to always open the URL and not let the builtin behavior occurs, which will not change to the opened page.
@boubaker boubaker requested a review from AzmiTouil December 3, 2024 10:39
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Dec 3, 2024
@boubaker boubaker enabled auto-merge (squash) December 3, 2024 10:39
Copy link

sonarcloud bot commented Dec 3, 2024

@boubaker boubaker merged commit 25d3a29 into develop Dec 3, 2024
5 checks passed
@boubaker boubaker deleted the meed-7881 branch December 3, 2024 10:58
exo-swf pushed a commit that referenced this pull request Dec 3, 2024
…ds#2622 (#4215)

Prior to this change, the external link behavior wasn't the same switch
Navigation Node display mode:
- Desktop Menu Item
- Desktop Menu Sub item (displayed in Second or Third Level)
- Mobile Menu Item
- Mobile Menu Sub item (displayed in Second or Third Level)

Thus, when clicking on external link in Mobile, the behavior is just to
open the URL as it was a current page URL. This change will introduce
the usage of **AutoLink** API in order to ensure the URL behavior
consistency comparing to provided link by the user. In addition, when a
Dash is used in user provided URL, the behavior has been improved to
always open the URL and not let the builtin behavior occurs, which will
not change to the opened page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants